Skip to content

ext/gmp: Make GMP class final #15121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 28, 2024
Merged

ext/gmp: Make GMP class final #15121

merged 2 commits into from
Jul 28, 2024

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Jul 27, 2024

@Girgias Girgias requested a review from kocsismate as a code owner July 27, 2024 11:03
devnexen
devnexen approved these changes Jul 27, 2024
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make enough sense

petk
petk reviewed Jul 27, 2024
View reviewed changes
@Girgias @petk
Update UPGRADING
693a3b1 
Co-authored-by: Peter Kokot <peterkokot@gmail.com>
@Girgias Girgias merged commit a50adda into php:master Jul 28, 2024
7 of 11 checks passed
@Girgias Girgias deleted the gmp-final branch July 28, 2024 12:03
TimWolla added a commit that referenced this pull request Jul 29, 2024
@TimWolla
[skip ci] Add missing name in NEWS for GH-15121
9083ce4
@jrfnl jrfnl mentioned this pull request Aug 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petk petk petk left review comments

@devnexen devnexen devnexen approved these changes

@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate is a code owner

Assignees
No one assigned
Labels
Extension: gmp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Girgias @petk @devnexen